[plugin] Added extensionDependency automatically downloading. Fixes: #4504 #5379
Conversation
JPinkney
changed the title
|
Should not it be a part of the vscode plugin resolver without any other changes? It could add a current extension, then look at it package.json, find dependencies, download them, unarchive them and then apply itself recursively till all dependencies are collected. Otherwise it looks like a broken abstraction, since plugin system assumes that any dependency should be resolved as a vscode extension. |
JPinkney
force-pushed
the
addExtensionDependency
branch
from
e0aedde to
e9b6699
Compare
|
@akosyakov I've just fixed it up so that it almost entirely lives in the VSCode plugin resolver, if you don't mind reviewing again! |
JPinkney
force-pushed
the
addExtensionDependency
branch
2 times, most recently
from
0b6c8d9 to
1acc628
Compare
akosyakov
added
plug-in system
|
@benoitf @akosyakov what do we need to do to move this PR forward? |
…heia#4504 Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
JPinkney
force-pushed
the
addExtensionDependency
branch
from
1acc628 to
0f28b77
Compare
There was a problem hiding this comment.
Code wise it looks good to me and worked very well as well 👍
@JPinkney i will let it sit for today and merge tomorrow morning, just in case if @theia-ide/plugin-system want to check changes to the deployment logic
It would be good to nominate your as a committer as well! I hope @tsmaeder can do it, if not let me know i will do.
This PR enables VSCode extension dependencies that comes from package.json.
You can test by using
deploy by plugin idcommand withvscode:extension/vscjava.vscode-java-debugandvscode-javawill automatically be installed beforevscjava.vscode-java-debugis.Fixes: #4504
Signed-off-by: Josh Pinkney joshpinkney@gmail.com